Switch rolling to *always* use testing repositories.#122
Conversation
The ROS PMC is considering a change to only support the testing repository for Rolling. While that change hasn't been finalized yet, it is not a bad idea for the Rolling docker images to always use testing; it is Rolling, after all, and whether it is unstable in testing in main or unstable in testing is mostly irrelevant. Update the code here to always have rolling point to the testing repositories. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
Note for reviewers: I have no idea how to test this out, any ideas welcome. |
MatthijsBurgh
left a comment
MatthijsBurgh
left a comment
There was a problem hiding this comment.
Logic seems correct to me.
I also don't know how to test this.
I've been out of the loop for a while, was this settled on by the ROS PMC? |
This was discussed in the ROS PMC meeting a few weeks ago: The short of it is that it is still up in the air. But I think that we should make this change now so that we can unblock the Rolling Docker images for now. If the PMC makes a different choice, we can always follow suit later on. |
|
@clalancette Who do you need a review from? |
|
This can be tested locally by building this docker image with the python environment for the templating engine, specifically changing the requirements file to pull in a remote PR branch: And then launching a container using that image to invoke the template scripts like the sea does: |
3 participants
The ROS PMC is considering a change to only support the testing repository for Rolling. While that change hasn't been finalized yet, it is not a bad idea for the Rolling docker images to always use testing; it is Rolling, after all, and whether it is unstable in testing in main or unstable in testing is mostly irrelevant. Update the code here to always have rolling point to the testing repositories.